Fix CI failing since rustc 1.65.0 #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
Two issues. 1. Backtrace BT format changed in Rust 1.65, causing bactrace_util::generate_backtraced_name to return an autogenerated name created via uuidv4. However, changes applied since then have actually made the happy path a hard requirement by expecting the resultant string to be of the form r"(.*)::(.*)::.*". This was the case when the test names were pulled from BT, but didn't work for autogenerated uuidv4 ones. This patch removed the uuid name generation from backtrace_util, and implemented it in mock_node in a different manner. 2. split-debuginfo=unpacked fails on Windows. Cargo should not forward this option if not supported, but this does not work in this case. Likely a regression in cargo-rustc interaction. For now removed this flag with an appropriate remark to get the CI going.
This option will make CI fail whenever new default lints are introduced to clippy. Exactly this has happened with update to rust 1.65.
MrDarthShoe
reviewed
Nov 7, 2022
nieznanysprawiciel
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three issues.
Market test suite
BT format changed in Rust 1.65, causing
bactrace_util::generate_backtraced_nameto return an autogenerated name created via uuidv4. However, changes applied since then have actually made the happy path a hard requirement by expecting the resultant string to be of the form(.*)::(.*)::.*. This was the case when the test names were pulled from the backtrace, but didn't work for autogenerated uuidv4 ones.This patch removed the uuid name generation from
backtrace_util, and implemented it inmock_nodein a different manner.split-debuginfo=unpackedfails on Windows.Cargo should not forward this option if not supported, but this does not work in this case. Likely a regression in cargo-rustc interaction. For now removed this flag with an appropriate remark to get the CI going. My fix in
cargois awaiting review (Fix split-debuginfo support detection rust-lang/cargo#11347), the option should be reenabled when it's merged and released.clippy
We passed
-D warningsto clippy, which (of course) made it fail on all warnings. Clippy 0.1.65 found more issues, and so it failed, bringing most of CI with it. This PR removes-D warnings.☑️ Definition of Done checklist